Add repo_data option to host registration command #1210
Conversation
|
Can one of the admins verify this patch? |
|
@dosas When would you like to get this PR merged? Before the upstream PR is merged or after? IIRC, we nailgun can not define fields that are not implemented in API unless an |
The above mentioned PR is already merged since a few months. The field should be part of the latest foreman? |
| @@ -6795,6 +6795,7 @@ def __init__(self, server_config=None, **kwargs): | |||
| 'update_packages': entity_fields.BooleanField(default=False), | |||
| 'force': entity_fields.BooleanField(default=False), | |||
| 'ignore_subman_errors': entity_fields.BooleanField(default=False), | |||
| 'repo_data': entity_fields.ListField(), | |||
There was a problem hiding this comment.
@dosas Thanks for adding this. Yes, I saw this option being added in foreman recently, and as per apidoc I see it is a Array with repository URL and corresponding GPG key URL, so I think ListField might not work here, so could you try DictField instead if it doesn't?
Also, I was wondering if you had any robottelo tests covering the repo_data? To verify this, we could run the PRT with that?
There was a problem hiding this comment.
IMO it is a list of dicts, so ListField should be correct. I have robottelo tests using this feature but they are not upstream.
The tests that are using api_register in robottelo do not use repo_data currently.
There was a problem hiding this comment.
ping @Gauravtalreja1
Gauravtalreja1
added
CherryPick
dosas
force-pushed
the
repo-data-host-registration
branch
from
c7965a4
to
02289d0
Compare
Description of changes
Add repo_data option to host registration command
Upstream API documentation, plugin, or feature links
The foreman upstream api is not up to date so I can only link the PR
theforeman/foreman#10162
Functional demonstration
I am executing it via robottelo I do not know how to extract the raw api call.
Additional Information
None